From: "DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
"t.lamprecht@proxmox.com" <t.lamprecht@proxmox.com>,
"aderumier@odiso.com" <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option.
Date: Tue, 5 Oct 2021 09:48:28 +0000 [thread overview]
Message-ID: <9bc649a123a2b2b77618fc681a09cb1912eb67c4.camel@groupe-cyllene.com> (raw)
In-Reply-To: <3108d8c2-2f35-7b4d-337d-22a297ee7086@proxmox.com>
+sub vmconfig_update_agent {
+ my ($conf, $opt, $value) = @_;
+
+ if ($conf->{$opt} && (my $old_agent = parse_guest_agent($conf))) {
+
+ my $agent = parse_guest_agent({$opt => $value});
+
+ # skip non hotpluggable value
+ if (safe_string_ne($agent->{enabled}, $old_agent->{enabled}) ||
+ safe_string_ne($agent->{type}, $old_agent->{type})) {
+ die "skip\n";
+ }
+ }
+ die "skip\n";
but this method always skips no matter what?
oh, sorry, it should be in an else (agent is disabled)
I just sent a fixed v2
prev parent reply other threads:[~2021-10-05 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 6:36 Alexandre Derumier
2021-10-05 5:21 ` Thomas Lamprecht
2021-10-05 9:48 ` DERUMIER, Alexandre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bc649a123a2b2b77618fc681a09cb1912eb67c4.camel@groupe-cyllene.com \
--to=alexandre.derumier@groupe-cyllene.com \
--cc=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.