all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/7] api types: add run-on-mount flag to SyncJobConfig
Date: Fri, 28 Feb 2025 09:21:07 +0100	[thread overview]
Message-ID: <9b7933af-a226-48b2-bcfe-35f64ad26ae5@proxmox.com> (raw)
In-Reply-To: <c181a1c9-256a-466d-bbed-1c2366df974a@proxmox.com>



On 2/4/25 15:24, Christian Ebner wrote:
> Should now be relocated to the pbs-api-types in `proxmox` repo, but 
> still applies cleanly.
> 
> further comments inline.
> On 1/16/25 07:45, Hannes Laimer wrote:
>> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
>> ---
>>   pbs-api-types/src/jobs.rs | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/pbs-api-types/src/jobs.rs b/pbs-api-types/src/jobs.rs
>> index 04631d920..da2565e07 100644
>> --- a/pbs-api-types/src/jobs.rs
>> +++ b/pbs-api-types/src/jobs.rs
>> @@ -622,6 +622,9 @@ pub struct SyncJobConfig {
>>       pub resync_corrupt: Option<bool>,
>>       #[serde(skip_serializing_if = "Option::is_none")]
>>       pub sync_direction: Option<SyncDirection>,
>> +    /// Run job when datastore is mounted
>> +    #[serde(default)]
>> +    pub run_on_mount: bool,
> 
> This should rather be an optional flag (like e.g. the resync corrupted) 
> in order to:
> 1. not fail for pre-existing configs
> 2. limit the number of properties if only the default ones are set
> 
> Further, it needs to be included also in the api schema description just 
> before the struct declaration.
> 

not sure why, but I assumed `#[serde(default)]` would to that, anyway,
will fix in next version

>>   }
>>   impl SyncJobConfig {
> 



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

  reply	other threads:[~2025-02-28  8:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16  6:45 [pbs-devel] [PATCH proxmox/proxmox-backup 0/7] trigger sync jobs on mount Hannes Laimer
2025-01-16  6:45 ` [pbs-devel] [PATCH proxmox 1/7] rest-server: add function that returns a join handle for spawn Hannes Laimer
2025-02-04 14:18   ` Christian Ebner
2025-01-16  6:45 ` [pbs-devel] [PATCH proxmox-backup 2/7] api types: add run-on-mount flag to SyncJobConfig Hannes Laimer
2025-02-04 14:24   ` Christian Ebner
2025-02-28  8:21     ` Hannes Laimer [this message]
2025-01-16  6:45 ` [pbs-devel] [PATCH proxmox-backup 3/7] api: admin: run configured sync jobs when a datastore is mounted Hannes Laimer
2025-02-04 14:33   ` Christian Ebner
2025-02-28  8:18     ` Hannes Laimer
2025-02-28 12:13       ` Christian Ebner
2025-01-16  6:45 ` [pbs-devel] [PATCH proxmox-backup 4/7] api: admin: trigger sync jobs only on datastore mount Hannes Laimer
2025-02-04 14:34   ` Christian Ebner
2025-05-15 11:33     ` Hannes Laimer
2025-05-15 11:45       ` Christian Ebner
2025-01-16  6:45 ` [pbs-devel] [PATCH proxmox-backup 5/7] bin: manager: run uuid_mount/mount tasks on the proxy Hannes Laimer
2025-02-04 14:41   ` Christian Ebner
2025-01-16  6:45 ` [pbs-devel] [PATCH proxmox-backup 6/7] ui: add run-on-mount checkbox to SyncJob form Hannes Laimer
2025-02-04 14:46   ` Christian Ebner
2025-02-28 11:54     ` Hannes Laimer
2025-02-04 15:22   ` Christian Ebner
2025-01-16  6:45 ` [pbs-devel] [PATCH proxmox-backup 7/7] ui: add task title for triggering sync jobs Hannes Laimer
2025-02-04 14:54 ` [pbs-devel] [PATCH proxmox/proxmox-backup 0/7] trigger sync jobs on mount Christian Ebner
2025-02-28  8:22   ` Hannes Laimer
2025-05-15 12:43 ` Hannes Laimer
  -- strict thread matches above, loose matches on Subject: below --
2024-12-11 10:40 [pbs-devel] [PATCH proxmox-backup " Hannes Laimer
2024-12-11 10:40 ` [pbs-devel] [PATCH proxmox-backup 2/7] api types: add run-on-mount flag to SyncJobConfig Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b7933af-a226-48b2-bcfe-35f64ad26ae5@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal