From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH] fix compressor loop-order
Date: Thu, 15 Jul 2021 11:31:43 +0200 [thread overview]
Message-ID: <9af2885d-e8ae-7172-6cab-edaa953ca6d5@proxmox.com> (raw)
In-Reply-To: <20210714165204.262432-1-s.ivanov@proxmox.com>
On 14.07.21 18:52, Stoiko Ivanov wrote:
> commit dbac106eb6e3cff405e57c0bb6a6dbe3cf307c52 introduced a flaw in
> the logic - once a file is downloaded the 'last;' statement exited the
> inner loop iterating over the compoentens instead of the outer one
> iterating over the compressors.
>
> since both do not inherently depend on each other simply swap them.
>
> noticed while trying to build a pmg-template in a clean environment
> with full repository configuration (before the tests worked due to
> leftover files in the infodir)
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> Sorry for the inconvenience!
>
> DAB.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-07-15 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 16:52 [pve-devel] " Stoiko Ivanov
2021-07-15 9:31 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9af2885d-e8ae-7172-6cab-edaa953ca6d5@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.