From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH widget-toolkit/proxmox-backup v2 0/5] fix #5463: add optional consent banner before login
Date: Wed, 5 Jun 2024 15:22:48 +0200 [thread overview]
Message-ID: <9a5e685e-d935-414a-93c7-6b3b46bda866@proxmox.com> (raw)
In-Reply-To: <20240604125014.210321-1-g.goller@proxmox.com>
did not look too closely at the code, but gave it a spin and found a few problems/
have suggestions:
* handlebars by default does html escaping (https://docs.rs/handlebars/latest/handlebars/#escaping)
so any of the reserved characters will be wrong
(namely as html escape sequence such as '"')
* that accidentally prevented code injection when directly editing the config file
this is something we should do even if we assume that the text was set through the api
just a simple search/replace of some specific characters such as "< etc. should be enough
* there is still a code execution potential, namely on the rendering part of the config
in configuration -> other (works e.g. by setting <svg onmouseover=alert(1)></svg>)
* it's not possible to delete the text again from the ui
* if it's deleted (by api or by hand) 'undefined' is rendered
* i really would like markdown support here too ;)
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-06-05 13:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 12:50 Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH widget-toolkit v2 1/5] window: add consent modal Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH widget-toolkit v2 2/5] form: add support for multiline textarea Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH proxmox-backup v2 3/5] api: add consent api handler and config option Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH proxmox-backup v2 4/5] ui: show consent banner before login Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH proxmox-backup v2 5/5] docs: add section about consent banner Gabriel Goller
2024-06-05 13:22 ` Dominik Csapak [this message]
2024-06-06 10:18 ` [pbs-devel] [PATCH widget-toolkit/proxmox-backup v2 0/5] fix #5463: add optional consent banner before login Gabriel Goller
2024-06-06 10:30 ` Dominik Csapak
2024-06-06 11:25 ` Gabriel Goller
2024-06-06 12:09 ` Dominik Csapak
2024-06-06 12:56 ` Gabriel Goller
2024-06-06 13:04 ` Thomas Lamprecht
2024-06-07 8:08 ` Gabriel Goller
2024-06-07 11:48 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a5e685e-d935-414a-93c7-6b3b46bda866@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.