From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager/docs] handle missed jobs better
Date: Thu, 2 Jun 2022 09:07:22 +0200 [thread overview]
Message-ID: <99b6d70c-d164-5457-4f91-cd27d4c2f25c@proxmox.com> (raw)
In-Reply-To: <20220601102321.4093592-1-d.csapak@proxmox.com>
Am 01/06/2022 um 12:23 schrieb Dominik Csapak:
> by adding a config option 'skip-missed' for jobs that skips the jobs
> on pvescheduler start and when changing from disabled -> enabled
>
> i did not use the systemd name 'persistent' since the name does
> not really convey what it means, so i tried to come up with
> a better name for it (the logic is just reversed from the systemd
> variant, and our default is 0)
>
for the record the off list exchange:
* skipping immediate "catch up" run on disable->enable change should be unconditionally
off
* "skip-missed" is somewhat double negative, rather negate that and use "persistent",
like systemd does, or "repeat-missed"
* the behaviour should then be off by default to avoid triggering lots of backups during
boot up.
* I'd move the box into advanced section in the gui
prev parent reply other threads:[~2022-06-02 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 10:23 Dominik Csapak
2022-06-01 10:23 ` [pve-devel] [PATCH manager 1/3] fix #4026: add 'skip-missed' option for jobs Dominik Csapak
2022-06-01 10:23 ` [pve-devel] [PATCH manager 2/3] fix #4053: enable 'skip-missed' behaviour also for change from disabled->enabled Dominik Csapak
2022-06-01 10:23 ` [pve-devel] [PATCH manager 3/3] ui: dc/Backup: add 'skip-missed' checkbox Dominik Csapak
2022-06-01 10:23 ` [pve-devel] [PATCH docs 1/1] vzdump: add section about 'skip-missed' Dominik Csapak
2022-06-02 7:07 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99b6d70c-d164-5457-4f91-cd27d4c2f25c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.