From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid crash with heavy IO on local VM disk
Date: Tue, 28 May 2024 10:01:07 +0200 [thread overview]
Message-ID: <99af0b60-d4f6-4ecd-90a4-b15d339268ec@proxmox.com> (raw)
In-Reply-To: <1716455155.i5mq0p043i.astroid@yuna.none>
Am 23.05.24 um 11:08 schrieb Fabian Grünbichler:
> one nit below, otherwise very nice to have this!
>
> On May 3, 2024 10:34 am, Fiona Ebner wrote:
>> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
>> index 8d9b35ae..649cfec4 100644
>> --- a/PVE/QemuMigrate.pm
>> +++ b/PVE/QemuMigrate.pm
>> @@ -1142,6 +1142,15 @@ sub phase2 {
>> $self->log('info', "$drive: start migration to $nbd_uri");
>> PVE::QemuServer::qemu_drive_mirror($vmid, $drive, $nbd_uri, $vmid, undef, $self->{storage_migration_jobs}, 'skip', undef, $bwlimit, $bitmap);
>> }
>> +
>> + my $kvm_version = PVE::QemuServer::kvm_user_version();
>
> wouldn't this need to check the *running* qemu binary for the migrated
> VM, not the *installed* qemu binary on the system?
>
Good catch! Yes, I copied/adapted this from the check for replication
which also does it wrong. I'll send a v2 fixing it (and remove the check
for replication for version 4.2 which is not needed nowadays anymore).
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-05-28 8:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 8:34 Fiona Ebner
2024-05-03 8:34 ` [pve-devel] [PATCH qemu-server 2/2] migration: add missing use statements Fiona Ebner
2024-05-23 9:03 ` [pve-devel] applied: " Fabian Grünbichler
2024-05-28 7:50 ` Fiona Ebner
2024-05-23 9:08 ` [pve-devel] [PATCH qemu-server 1/2] migration: avoid crash with heavy IO on local VM disk Fabian Grünbichler
2024-05-23 9:29 ` Thomas Lamprecht
2024-05-28 8:01 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99af0b60-d4f6-4ecd-90a4-b15d339268ec@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.