all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/2] debug cli: improve output, optionally compare file content for `diff archive`
Date: Thu, 1 Dec 2022 09:02:33 +0100	[thread overview]
Message-ID: <9942b2ee-8e2d-c47c-a71a-b5ba30d12eba@proxmox.com> (raw)
In-Reply-To: <a01f791a-3f00-cbac-89f8-2072638cd7b1@proxmox.com>

Am 01/12/2022 um 08:30 schrieb Lukas Wagner:
> 
> On 11/30/22 17:27, Thomas Lamprecht wrote:
>> nothing against this approach, but what about color coding?
>> (maybe additionally or as either/or?)
>>
> 
> That is already on my 'future improvements' list. My approach would probably
> be to leave the current output format as-is, and then add coloring on top
> as eye candy (on by default, disabled by flag/envvar or if stdout is not a tty)
> 
> 

Hmm, I could imagine that there might be some that would like to avoid a extra
* adding "noise" if I got all information from the color anyway, but can be always
improved later, if anybody requests it at all.

For the "should I color choice" the nicest and flexibel way that most CLI tools
adhere too is having tree level:

- always
- never
- auto (stdout on if tty)

As with "always" it allows one also for checking out bigger outputs in a pager with
color, e.g., by piping to `less -R`.




  reply	other threads:[~2022-12-01  8:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 14:17 Lukas Wagner
2022-11-29 14:17 ` [pbs-devel] [PATCH proxmox-backup 1/2] debug cli: show more file attributes for `diff archive` command Lukas Wagner
2022-11-29 14:17 ` [pbs-devel] [PATCH proxmox-backup 2/2] debug cli: add 'compare-content' flag to " Lukas Wagner
2022-12-01 13:29   ` Stefan Hanreich
2022-12-01 13:30     ` Stefan Hanreich
2022-11-30 16:27 ` [pbs-devel] [PATCH proxmox-backup 0/2] debug cli: improve output, optionally compare file content for `diff archive` Thomas Lamprecht
2022-12-01  7:30   ` Lukas Wagner
2022-12-01  8:02     ` Thomas Lamprecht [this message]
2022-12-01 13:29 ` Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9942b2ee-8e2d-c47c-a71a-b5ba30d12eba@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal