Re: [pbs-devel] [PATCH proxmox-backup v2 00/14] various clippy fixes

[Dominik Csapak <d.csapak@proxmox.com>]

On 4/18/21 16:26, Dietmar Maurer wrote:
> Some of those changes may make sense, but it is really
> a PITA to review them. Every change can break the code an introduce new
> errors (which already happened in the past).
> 

any examples for those errors? (just for my curiosity)

can i do anything to make reviewing easier?

> On the other side, It is hard to see any advantages for
> most of those changes.
> 

IMHO, most changes do make the code better and/or more
readable (e.g. nested ifs, complex types, safety annotation,
absurd extreme comparisons), any specific ones you
dislike?

if there are some classes of warnings/errors that do not
make sense, it would probably be good if we introduce some
custom clippy configs in our repos