Re: [PATCH qemu-server 3/3] api: update vm: fork before locking

[Dominik Csapak <d.csapak@proxmox.com>]

On 7/3/26 1:44 PM, Fiona Ebner wrote:
> Am 03.07.26 um 11:41 AM schrieb Dominik Csapak:
>> one remark/question:
>>
>> would it make for a nicer interface for the load_and_check_config
>> if we'd pass the delete list into it instead of using
>> catching the outer closure variable?
>>
>> that way we wouldn't have to guard the 'push @delete' statements
>> and could simply pass an empty list into it when we don't want
>> to add them.
>>
>> the only difference it would make is that inside, we wouldn't
>> delete the $conf->{lock} there but since we discard that
>> before using it when we don't want to update delete this
>> should be fine?
> 
> As discussed during lunch too, in case the vmstate is being deleted,
> it's important that the load_and_check_config() gets the actual $delete
> list. Because if we pass an empty list, then we don't delete the
> suspended lock, and then the check_lock() right below would fail.
> 
> Of course, this could be handled by adapting the function with
> additional arguments, but the guard seems rather straightforward to me,
> so I would be inclined to just keep it like that.


yes, sure makes sense (i overlooked the check_lock call)