Re: [PATCH-SERIES qemu-server 0/3] fix #7743: api: disk import: avoid locking twice when importing from OVA or same VM

[Manuel Federanko <m.federanko@proxmox.com>]

Hi,

I built the package, installed it and check that the issue no longer
exists with my reproducer [0].

Everything seems to be working fine.

Thanks!

Tested-by: Manuel Federanko <m.federanko@proxmox.com>

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=7743

On 2026-06-29 2:46 PM, Fiona Ebner wrote:
> When import_from_volid->() is called, the VM configuration of the
> destination VM is already locked. In case the source volume belongs to
> the same VM, there would be a second attempt to lock the config. In
> particular, this also happens when importing from OVA, because the
> source image is first extracted and belongs to the same VM.
> 
> Additionally, the update VM API call is changed to fork before
> locking using the usual early+repeated checks pattern.
> 
> qemu-server:
> 
> Fiona Ebner (3):
>   api: disk import: remove unused wrongly named variable
>   fix #7743: api: disk import: avoid locking twice when importing from
>     OVA or same VM
>   api: update vm: fork before locking
> 
>  src/PVE/API2/Qemu.pm | 780 ++++++++++++++++++++++---------------------
>  1 file changed, 397 insertions(+), 383 deletions(-)
> 
> 
> Summary over all repositories:
>   1 files changed, 397 insertions(+), 383 deletions(-)
>