Re: [pbs-devel] [PATCH proxmox, proxmox-backup 0/3] Add support for HTTP to HTTPS redirection

[Max Carrara <m.carrara@proxmox.com>]

On 6/23/23 12:55, Thomas Lamprecht wrote:
> Am 23/06/2023 um 12:15 schrieb Max Carrara:
>> On 6/22/23 11:15, Max Carrara wrote:
>>> This patch series adds support for redirecting HTTP requests to HTTPS. This is
>>> done by peeking into the incoming TCP stream's buffer in order to check whether
>>> the client initiates a TLS handshake or not.
>>>
>>> Secure and insecure connections are then sent along separate channels, allowing
>>> them to be handled by different `hyper::Server`s (if so desired).
>>>
>>> Finally, `proxmox-backup-proxy` is adapted correspondingly, making it a little
>>> more convenient to access PBS via its web interface.
>>>
>>> proxmox:
>>>
>>> Max Carrara (2):
>>>   rest-server: Add `BiAcceptBuilder`
>>>   rest-server: Add `Redirector`
>>>
>>>  proxmox-rest-server/src/connection.rs | 327 ++++++++++++++++++++++++++
>>>  proxmox-rest-server/src/lib.rs        |   2 +-
>>>  proxmox-rest-server/src/rest.rs       |  76 ++++++
>>>  3 files changed, 404 insertions(+), 1 deletion(-)
>>>
>>>
>>> proxmox-backup:
>>>
>>> Max Carrara (1):
>>>   proxy: redirect HTTP requests to HTTPS
>>>
>>>  src/bin/proxmox-backup-proxy.rs | 45 ++++++++++++++++++++++++++++-----
>>>  1 file changed, 38 insertions(+), 7 deletions(-)
>>>
>>
>> Note: This series was built and tested on the `stable-2` branches of
>> either repo, but applies on both `master` branches as well.
>>
> 
> Ok but I'd rather only apply this to master. This isn't a clear targeted bug fix,
> so rather would keep away any potential regression from the stable branch.
> 

FYI: just built and tested it on master; works as as of commit
54cb9be8edba5e78071275df892516742fa26a75

Just wanted to make sure myself, even though Lukas already tested it
(thanks!)