From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup v2 1/2] fix #5946: disks: wipe: ensure GPT header backup is wiped
Date: Tue, 11 Feb 2025 19:39:24 +0100 [thread overview]
Message-ID: <97c61ed9-4c9d-4590-a90f-8a777f6e3e38@proxmox.com> (raw)
In-Reply-To: <20250211162639.141541-2-f.schauer@proxmox.com>
Am 11.02.25 um 17:26 schrieb Filip Schauer:
> When wiping a block device with a GUID partition table, the header
> backup might get left behind at the end of the disk. This commit also
> wipes the last 4096 bytes of the disk, making sure that a GPT header
> backup is erased, even from disks with 4k sector sizes.
change-wise I'd have preferred switching over from dd to writing ourself
in a first patch and then adding the code for clearing the GPT backup header
in a second patch, that's much easier to process and review compared to
mixing those two things.
The resulting code itself looks OK to me though.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-02-11 18:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 16:26 [pbs-devel] [PATCH backup v2 0/2] " Filip Schauer
2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 1/2] " Filip Schauer
2025-02-11 18:39 ` Thomas Lamprecht [this message]
2025-02-12 11:01 ` Filip Schauer
2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 2/2] disks: wipe: only zero out the first 1 MiB Filip Schauer
2025-02-11 18:42 ` Thomas Lamprecht
2025-02-12 10:24 ` Filip Schauer
2025-02-12 13:44 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97c61ed9-4c9d-4590-a90f-8a777f6e3e38@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.