From: Daniel Kral <d.kral@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Wolfgang Bumiller" <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [RFC container] setup: remove deprecated dsa from ssh host key generation
Date: Fri, 27 Jun 2025 11:44:01 +0200 [thread overview]
Message-ID: <97640bb0-baea-4c7c-9a11-d94851c6caba@proxmox.com> (raw)
In-Reply-To: <2144670364.9427.1751013988849@192.168.2.153>
On 6/27/25 10:46, Fabian Grünbichler wrote:
> we already have PVE::LXC::Setup::rewrite_ssh_host_keys which AFAICT is
> called unconditionally in Setup::post_create_hook even for unmanaged
> containers, given that precedent I think we can just extend that..
Oh wait, just was reminded that rewrite_ssh_host_keys is unconditionally
called in Setup::post_create_hook, but ssh_host_key_types_to_generate is
overwritten in Setup::Unmanaged to return empty, i.e. do not rewrite any
ssh host keys.
Should we still extend it here or keep it in
Setup::Base::post_create_hook(...)? Else I send a tested patch with
those changes afterwards :)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-27 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 9:56 Daniel Kral
2025-06-26 11:36 ` Wolfgang Bumiller
2025-06-27 5:04 ` Fabian Grünbichler
2025-06-27 8:20 ` Daniel Kral
2025-06-27 8:46 ` Fabian Grünbichler
2025-06-27 8:59 ` Daniel Kral
2025-06-27 9:06 ` Fabian Grünbichler
2025-06-27 9:44 ` Daniel Kral [this message]
2025-06-27 10:11 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97640bb0-baea-4c7c-9a11-d94851c6caba@proxmox.com \
--to=d.kral@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.