Re: [pve-devel] [PATCH pve-manager] sdn: adapt edit panels for new API endpoints

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

For the record, two things inline

Am 22/11/2023 um 18:41 schrieb Stefan Hanreich:
> diff --git a/www/manager6/sdn/zones/Base.js b/www/manager6/sdn/zones/Base.js
> index db9b47b18..2eecb101a 100644
> --- a/www/manager6/sdn/zones/Base.js
> +++ b/www/manager6/sdn/zones/Base.js
> @@ -34,9 +34,9 @@ Ext.define('PVE.panel.SDNZoneBase', {
>                  minValue: 100,
>                  maxValue: 65000,
>                  fieldLabel: 'MTU',
> -                skipEmptyText: true,
>                  allowBlank: true,
>                  emptyText: 'auto',
> +		deleteEmpty: !me.isCreate,

FYI: CBind doesn't works here because the items are set in initComponents, but
the CBind mixin is configured to run before that (see its `mixinConfig`)

If you'd have switched all to a fully declarative implementation it would have
worked.

Maybe we could detect that explicitly (delete done cbinds in the current hook
and warn if any new is found on a newly introduced after-initComponent one)

>              },
>              {
>                  xtype: 'pveNodeSelector',
> diff --git a/www/manager6/sdn/zones/EvpnEdit.js b/www/manager6/sdn/zones/EvpnEdit.js
> index cac1ef4d5..a08faef2d 100644
> --- a/www/manager6/sdn/zones/EvpnEdit.js
> +++ b/www/manager6/sdn/zones/EvpnEdit.js
> @@ -8,30 +8,8 @@ Ext.define('PVE.sdn.zones.EvpnInputPanel', {

> +		uncheckedValue: null,
> +		deleteEmpty: !me.isCreate,



Same here w.r.t. cbind was not working, but what I actually asked myself why
we do not couple the deleteEmpty to uncheckedValue=null, as that makes no
sense otherwise.