From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Markus Frank <m.frank@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 5/6] feature #3690: ui: enable wipe disk in StorageAndDisks
Date: Mon, 27 Nov 2023 17:29:07 +0100 [thread overview]
Message-ID: <97114a34-8721-4764-994c-912a961954d4@proxmox.com> (raw)
In-Reply-To: <20231110135010.106015-5-m.frank@proxmox.com>
General note about the UI patch:
You should also add an entry in in www/Utils.js ->
override_task_descriptions, so that tasks of type 'wipedisk' are
rendered properly in the task history. I guess you can just copy the
entry from PVE.
On 11/10/23 14:50, Markus Frank wrote:
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> www/panel/StorageAndDisks.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/panel/StorageAndDisks.js b/www/panel/StorageAndDisks.js
> index 7bd7042c..e9d7ed19 100644
> --- a/www/panel/StorageAndDisks.js
> +++ b/www/panel/StorageAndDisks.js
> @@ -17,6 +17,7 @@ Ext.define('PBS.StorageAndDiskPanel', {
> xtype: 'pmxDiskList',
> title: gettext('Disks'),
> includePartitions: true,
> + supportsWipeDisk: true,
> itemId: 'disks',
> iconCls: 'fa fa-hdd-o',
> },
--
- Lukas
next prev parent reply other threads:[~2023-11-27 16:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 13:50 [pbs-devel] [PATCH proxmox-backup 1/6] feature #3690: add regex, format & schema for partition names to pbs-api-types Markus Frank
2023-11-10 13:50 ` [pbs-devel] [PATCH proxmox-backup 2/6] feature #3690: add wipe_blockdev & change_parttype rust equivalent Markus Frank
2023-11-27 16:29 ` Lukas Wagner
2023-11-10 13:50 ` [pbs-devel] [PATCH proxmox-backup 3/6] feature #3690: api: add function wipe_disk Markus Frank
2023-11-10 13:50 ` [pbs-devel] [PATCH proxmox-backup 4/6] feature #3690: cli: " Markus Frank
2023-11-10 13:50 ` [pbs-devel] [PATCH proxmox-backup 5/6] feature #3690: ui: enable wipe disk in StorageAndDisks Markus Frank
2023-11-27 16:29 ` Lukas Wagner [this message]
2023-11-10 13:50 ` [pbs-devel] [PATCH proxmox-backup 6/6] prohibit disk wipe of EFI partition Markus Frank
2023-11-27 16:29 ` Lukas Wagner
2023-11-27 16:29 ` [pbs-devel] [PATCH proxmox-backup 1/6] feature #3690: add regex, format & schema for partition names to pbs-api-types Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97114a34-8721-4764-994c-912a961954d4@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.