all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 manager 2/2] ui: lxc: add edit window for device passthrough
Date: Tue, 16 Apr 2024 15:57:06 +0200	[thread overview]
Message-ID: <96b03505-ddf8-4211-b935-4b2a4e6bdc66@proxmox.com> (raw)
In-Reply-To: <20240416121002.135845-3-f.schauer@proxmox.com>

Am 16.04.24 um 14:10 schrieb Filip Schauer:
> +
> +    cbind: {
> +	confid: '{confid}',
> +	isCreate: get => !get('confid'),
> +    },

Can't the above be removed while...

> +
> +    items: [
> +	{
> +	    xtype: 'proxmoxintegerfield',
> +	    name: 'devid',
> +	    fieldLabel: gettext('Passthrough ID'),
> +	    minValue: 0,
> +	    maxValue: PVE.Utils.dev_count - 1,
> +	    hidden: true,
> +	    allowBlank: false,
> +	    disabled: true,
> +	    labelAlign: 'right',
> +	    bind: {

...using cbind instead of bind here?

> +		hidden: '{!isCreate}',
> +		disabled: '{!isCreate}',
> +	    },




  reply	other threads:[~2024-04-16 13:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 12:10 [pve-devel] [PATCH v4 manager 0/2] " Filip Schauer
2024-04-16 12:10 ` [pve-devel] [PATCH v4 manager 1/2] utils: clarify naming of LXC mount point utils Filip Schauer
2024-04-16 12:10 ` [pve-devel] [PATCH v4 manager 2/2] ui: lxc: add edit window for device passthrough Filip Schauer
2024-04-16 13:57   ` Fiona Ebner [this message]
2024-04-17  8:47     ` Filip Schauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96b03505-ddf8-4211-b935-4b2a4e6bdc66@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal