Re: [pve-devel] [PATCH manager 7/7] ui: cpu flag selector: query CPU flag list via API

[Fiona Ebner <f.ebner@proxmox.com>]

Am 06.11.25 um 5:57 PM schrieb Daniel Kral:
> On Fri Oct 31, 2025 at 1:27 PM CET, Fiona Ebner wrote:
>>          // ExtJS does not has a nice getAllRecords interface for stores :/
>>          store.queryBy(Ext.returnTrue).each(function (rec) {
> 
> unrelated to the patch, but shouldn't `store.getData()` return all the
> records? `store.getData().getSource()` would be the equivalent, but as
> the store for cpu capabilities isn't filtered right now, the former
> should work.

I'll check it out for v2.

>> +    setValue: function (value) {
>> +        let me = this;
>> +
>> +        me.value = value || '';
>> +
>> +        if (me.getStore().isLoaded()) {
>> +            me.adjustForValue();
> 
> Shouldn't this be `me.adjustStoreForValue();`? :)

Good catch!

> I haven't yet found a way to trigger this though - neither in the Create
> wizard nor the CPU modal with and without values - but maybe my
> debugging strategy here is a bit wrong. How did you trigger it?

I did not actually manage to trigger it either. I'm not sure it can even
happen in practice right now. It makes sense for future-proofing, but I
missed adapting to the last rename of the function I did.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel