Re: [pbs-devel] [PATCH v2 proxmox{, -backup} 0/2] Move ProcessLocker to tmpfs

[Gabriel Goller <g.goller@proxmox.com>]

On 12/6/23 15:14, Fabian Grünbichler wrote:
>> Gabriel Goller <g.goller@proxmox.com> hat am 06.12.2023 14:56 CET geschrieben:
>> On 12/6/23 14:41, Fabian Grünbichler wrote:
>>> [..]
>> Just spoke with Stefan Sterz about this and we will probably
>> apply/release this with a major version bump (kernel update), so that
>> the user
>> is forced to reboot the system (same as with his tmpfs locking series).
>> I don't think there is another way, because the lockfiles get moved to
>> another dir. Although F_SETLK and F_OFD_SETLK should be compatible,
>> so having one process use F_SETLK and another F_OFD_SETLK *should* still
>> work (don't take my word for it though).
> that doesn't really help though, unless we also add machinery to detect the missing reboot and block any process-locker-requiring stuff in the new process until it has happened? or we make "set all datastores to read-only or offline" a requirement for upgrading from 3 to 4, instead of optional like for 2 to 3[0]. otherwise even just the time between "postinst of PBS package is called" to "upgrade of whole system is fully done" can be big enough to cause a problem..
>
> 0: https://pbs.proxmox.com/wiki/index.php/Upgrade_from_2_to_3#Optional:_Enable_Maintenance_Mode
That's a good idea.
Optionally we could also somehow remove the `.lock` file in the 
datastore and remove the `.create(true)`,
so that creating the 'old' `.lock` file will fail?
Although not sure how we would do this...

But can we also somehow force the user to have the datastore in a 
maintenance mode? I guess not...