Re: [PATCH proxmox-backup v3] fix #7187: report: add ethtool output for physical interfaces

[Christian Ebner <c.ebner@proxmox.com>]

On 5/15/26 10:39 AM, Erik Fastermann wrote:
> Adding ethtool output to the report provides visibility into actual and
> supported NIC link speeds, making it much easier to diagnose network
> performance issues, negotiation failures, and configuration mismatches.
> It also reduces support back-and-forth.
> 

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7187

although only the PBS part for this particular case.

> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>

Code looks okay to me and this produces the expected output.

Only concern, although out of scope for this patch:
As noted in server/src/report.rs on the PDM side, code was basically 
copied over from PBS for the initial implementation. The comment there 
already suggest refactoring and splitting into a `proxmox-system-report` 
crate.

It would make sense to do this sooner than later, as the reports are 
likely to further diverge over time and code duplication to increase.

Could you tackle this as followup?

Maybe further split into product common commands (and files, ecc.) and 
product specific commands (and files, ecc.). Product specific parts 
could then maybe be defined as callbacks?