From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B2F891FF14C for ; Fri, 26 Jun 2026 11:06:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 05C02A901; Fri, 26 Jun 2026 11:06:41 +0200 (CEST) Message-ID: <9657d696-2bd6-4e0b-a067-fb4480dad7d3@proxmox.com> Date: Fri, 26 Jun 2026 11:06:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v3] fix #7187: report: add ethtool output for physical interfaces To: Erik Fastermann , pbs-devel@lists.proxmox.com References: <20260515083918.10590-1-e.fastermann@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260515083918.10590-1-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782464759158 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com,report.rs] Message-ID-Hash: ZVOVYMCMIJ2ZCYLAHHO6IUQNB4FAM7HN X-Message-ID-Hash: ZVOVYMCMIJ2ZCYLAHHO6IUQNB4FAM7HN X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/15/26 10:39 AM, Erik Fastermann wrote: > Adding ethtool output to the report provides visibility into actual and > supported NIC link speeds, making it much easier to diagnose network > performance issues, negotiation failures, and configuration mismatches. > It also reduces support back-and-forth. > Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7187 although only the PBS part for this particular case. > Signed-off-by: Erik Fastermann Reviewed-by: Christian Ebner Tested-by: Christian Ebner Code looks okay to me and this produces the expected output. Only concern, although out of scope for this patch: As noted in server/src/report.rs on the PDM side, code was basically copied over from PBS for the initial implementation. The comment there already suggest refactoring and splitting into a `proxmox-system-report` crate. It would make sense to do this sooner than later, as the reports are likely to further diverge over time and code duplication to increase. Could you tackle this as followup? Maybe further split into product common commands (and files, ecc.) and product specific commands (and files, ecc.). Product specific parts could then maybe be defined as callbacks?