From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox v2 0/3] fix #6161: time: Split parse_time_spec parser into two
Date: Wed, 27 Aug 2025 11:02:02 +0200 [thread overview]
Message-ID: <963303ac-4794-4b9f-83c5-04101f29904c@proxmox.com> (raw)
In-Reply-To: <s8oplchb1ja.fsf@proxmox.com>
On 27/08/2025 10:40, Maximiliano Sandoval wrote:
>> What about the backward compat concerns from Dominik and Fiona, I see
>> nothing written anywhere in this series addressing them, or did I just
>> overlooked that?
>>
>> Could we treat only serializing strict and deserializing not?
> I am not sure if it is possible or something we do in general. We would
> need to be strict when de-serializing from the web UI (to prevent wrong
> entries from reaching the configuration file) but be more lenient when
> de-serializing from the configuration file.
>
Yes, that's the idea ;-) It is a pattern we employed quite a few times
in the past already.
I.e., accept and directly map legacy variants to the "good format" on
parse, then when it gets serialized out again it will be automatically
in the modern "correct" format.
As all that was parsed got transformed to new one can safely block any
legacy variant on serialization, as there such old variants must come
from the API then. Rejecting this in the UI already is rather extra
convenience that is nice to have but not a bare necessity.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-08-27 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 12:43 Maximiliano Sandoval
2025-08-13 12:43 ` [pbs-devel] [PATCH proxmox v2 1/3] time: Add traits to DateTimeValue and TimeSpec Maximiliano Sandoval
2025-08-13 12:43 ` [pbs-devel] [PATCH proxmox v2 2/3] fix #6161: time: Split parse_time_spec parser into two Maximiliano Sandoval
2025-08-13 12:43 ` [pbs-devel] [PATCH proxmox v2 3/3] time: Add more calendat event tests Maximiliano Sandoval
2025-08-26 21:58 ` [pbs-devel] [PATCH proxmox v2 0/3] fix #6161: time: Split parse_time_spec parser into two Thomas Lamprecht
2025-08-27 8:40 ` Maximiliano Sandoval
2025-08-27 9:02 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=963303ac-4794-4b9f-83c5-04101f29904c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.