From: alexandre derumier <aderumier@odiso.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-network] vnet/subnet : add skipdns option
Date: Tue, 13 Jul 2021 08:17:05 +0200 [thread overview]
Message-ID: <961ddec49874e5d20d912588fc21a1da4cf37c8d.camel@odiso.com> (raw)
In-Reply-To: <6788b7d7-f389-606b-b117-d72b0c585b4d@proxmox.com>
Le mardi 13 juillet 2021 à 06:41 +0200, Thomas Lamprecht a écrit :
> On 12.07.21 00:48, Alexandre Derumier wrote:
> > allow to register ip to ipam without dns registration.
> > can be used for temp/pending ip for example
> >
> > Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> > ---
> > PVE/Network/SDN/Subnets.pm | 70 ++++++++++++++++++++++------------
> > ----
> > PVE/Network/SDN/Vnets.pm | 16 ++++-----
> > 2 files changed, 49 insertions(+), 37 deletions(-)
> >
>
> looks OK, I wonder if we'd be more future proof if we went for adding
> a %param hash
> (or as reference with $param) instead, with the skip dns options as
> property?
>
> Not to sure how much change potential there's here.
Ok no problem, I'll look for this.
(I'm currently reworking lxc ipam too, based on my last work on qemu-
server)
>
> btw., did you checked out newer ifupdown2 already? I saw that
> upstream added a changelog
> entry already, but not yet tagged as release.
>
I'm currently testing it. (I had asked to julien to push theses last
patches 2 week ago to have them before proxmox7 release, but it was a
bit late ^_^)
https://github.com/CumulusNetworks/ifupdown2/issues/211
I known they are a dhcp fix, needed by a user on the forum
https://github.com/CumulusNetworks/ifupdown2/commit/1eacb76b3ab634838559d3a2b5a4e39b98b21d10
I'll try to finish my tests the week. (I'm going to holiday next week
for 3 weeks)
next prev parent reply other threads:[~2021-07-13 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 22:48 Alexandre Derumier
2021-07-13 4:41 ` Thomas Lamprecht
2021-07-13 6:17 ` alexandre derumier [this message]
2021-07-13 6:56 ` alexandre derumier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=961ddec49874e5d20d912588fc21a1da4cf37c8d.camel@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.