all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pbs-devel] applied: [PATCH] api: removable datastore: downgrade device already mounted error to info
Date: Wed, 27 Nov 2024 12:50:48 +0100	[thread overview]
Message-ID: <96119412-277a-4964-a722-3aadf4dd9c88@proxmox.com> (raw)
In-Reply-To: <20241127104235.154875-1-a.lauterer@proxmox.com>

Am 27.11.24 um 11:42 schrieb Aaron Lauterer:
> pbs-datastore::datastore::is_datastore_mounted_at() verifies that the
> mounted file system has the expected UUID. Therefore we don't have to
> error out if we try to mount an already mounted removable datastore.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  src/api2/admin/datastore.rs | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, thanks!

But IMO the info we get from is_datastore_mounted_at could be a bit more
telling, or well, I'd like to be able to bail here if the backing-device
is mounted somewhere else or if the wrong device is mounted on our path.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      reply	other threads:[~2024-11-27 11:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-27 10:42 [pbs-devel] " Aaron Lauterer
2024-11-27 11:50 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96119412-277a-4964-a722-3aadf4dd9c88@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal