From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH common] safe_read_from: bump default size limit to 512k
Date: Wed, 19 Aug 2020 07:39:08 +0200 [thread overview]
Message-ID: <94ef31ea-5d60-9946-7923-0e79154a47ab@proxmox.com> (raw)
In-Reply-To: <20200814074833.673784-1-f.gruenbichler@proxmox.com>
On 14.08.20 09:48, Fabian Grünbichler wrote:
> this is (via file_get_contents and file_copy) used for reading from
> pmxcfs, which has a file size limit of 512k. since quite a number of
> call sites would need to explicitly override this (and then get updated
> if we bump the limit on the pmxcfs side again in the future), making our
> default file reader compatible by default seems the better solution.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> actual real-world example of hitting this issue:
>
> https://forum.proxmox.com/threads/backup-failed-file-etc-pve-firewall-100-fw-too-long-aborting.74348/
>
> src/PVE/Tools.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-08-19 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 7:48 [pve-devel] " Fabian Grünbichler
2020-08-19 5:39 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94ef31ea-5d60-9946-7923-0e79154a47ab@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.