Re: [pve-devel] [PATCH docs 1/2] pvecm: Add required -r to rm

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 22.07.20 12:20, Dominic Jäger wrote:
> /etc/corosync/* includes the directory uidgid.d.
> Consequentlly, a correct rm call requires -r.

Does leaving this directory left-over causes any issues?

IIRC, I omit the "-r" explicitly as there can be also a directory from
a qdevice or other ones, which we do not want to remove - to level
corosync/* files where all desired to be removed, thus this rm varian.

But, maybe we should rather change it to:
# rm -f /etc/corosync/corosync.conf /etc/corosync/authkey

to make that more explicit

> 
> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
> ---
>  pvecm.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pvecm.adoc b/pvecm.adoc
> index 4bf2f59..9207571 100644
> --- a/pvecm.adoc
> +++ b/pvecm.adoc
> @@ -414,7 +414,7 @@ Delete the corosync configuration files:
>  [source,bash]
>  ----
>  rm /etc/pve/corosync.conf
> -rm /etc/corosync/*
> +rm -r /etc/corosync/*
>  ----
>  
>  You can now start the filesystem again as normal service:
>