Re: [pve-devel] [PATCH manager v7 07/14] ui: add form/Tag

[Aaron Lauterer <a.lauterer@proxmox.com>]

This component seems to not be working as expected.

In Firefox (105.0) I get all kinds of glitches and investigating it a bit, it 
seems like the HTML & CSS classes manipulation doesn't seem to work correctly. 
For example, if I edit an existing tag and select another existing one from the 
appearing drop down menu, the tag has a different set of HTML tags than before.

The "Add tag" button also seems somewhat broken in that regard, e.g. showing the 
plus icon more than once.


On Chromium (105.0.5195.102), I noticed, that I cannot select a pre-existing tag 
when adding a new or editing an existing tag, but the tags themselves look okay.

I would also recommend that we do test this in Safari and Edge (the officially 
supported browser).


On 6/21/22 11:20, Dominik Csapak wrote:
> displays a single tag, with the ability to edit inline on click (when
> the mode is set to editable). This brings up a list of globally available tags
> for simple selection.
> 
> Also has a mode for adding a new Tag.
> 
> This has a 'layoutCallback' which will be called on input, so that the parent
> component can update the layout when the content changes.
> This is necessary since we circumvent the extjs logic for updating.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   www/manager6/Makefile    |   1 +
>   www/manager6/form/Tag.js | 276 +++++++++++++++++++++++++++++++++++++++
>   2 files changed, 277 insertions(+)
>   create mode 100644 www/manager6/form/Tag.js
>