From: Dominik Csapak <d.csapak@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server v3 3/3] tests: cfg2cmd: add some architecture tests
Date: Tue, 10 Feb 2026 15:45:49 +0100 [thread overview]
Message-ID: <949e3f50-46af-4d71-9b1c-e1684eac9eae@proxmox.com> (raw)
In-Reply-To: <a34ac385-b5a8-4d31-b91c-23f7f8312bcc@proxmox.com>
On 2/10/26 3:35 PM, Fiona Ebner wrote:
> Am 10.02.26 um 3:32 PM schrieb Dominik Csapak:
>> On 2/10/26 2:20 PM, Fiona Ebner wrote:
>>> Am 05.02.26 um 3:19 PM schrieb Dominik Csapak:
>>>> one for manually setting
>>>> arch: aarch64
>>>>
>>>> in the config for an 'x86_64' host architecture, and one where
>>>> we don't have 'arch' set in the config on an aarch64 host.
>>>>
>>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>>
>>> Note that this makes pve-edk2-firmware-aarch64 a build-dependency.
>>> Should either be explicitly added in d/control or avoided.
>>
>> why is that? the tests themselves don't need to access the actual files,
>> or do they?
>
> Currently they do, in PVE::QemuServer::OVMF, get_ovmf_files() and
> afterwards when getting the size. Could be mocked of course.
ah thanks for pointing that out.
i'd send a v4 with an extra patch that mocks this too, so we
don't have to depend on the actual files being installed for
building the package
next prev parent reply other threads:[~2026-02-10 14:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 14:17 [PATCH qemu-server v3 0/3] improve multiarch build support Dominik Csapak
2026-02-05 14:17 ` [PATCH qemu-server v3 1/3] tests: improve multiarch build support by introducing local get_host_arch helper Dominik Csapak
2026-02-10 13:22 ` Fiona Ebner
2026-02-05 14:17 ` [PATCH qemu-server v3 2/3] tests: improve multiarch build support by allowing re-init of cpu models Dominik Csapak
2026-02-10 13:22 ` Fiona Ebner
2026-02-10 14:33 ` Dominik Csapak
2026-02-05 14:17 ` [PATCH qemu-server v3 3/3] tests: cfg2cmd: add some architecture tests Dominik Csapak
2026-02-10 13:22 ` Fiona Ebner
2026-02-10 14:34 ` Dominik Csapak
2026-02-10 14:37 ` Fiona Ebner
2026-02-10 14:45 ` Dominik Csapak [this message]
2026-02-11 9:27 ` superseded: [PATCH qemu-server v3 0/3] improve multiarch build support Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=949e3f50-46af-4d71-9b1c-e1684eac9eae@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.