From: Dominik Csapak <d.csapak@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] fix: ui: sync job: switch rate limit based on sync direction
Date: Mon, 17 Mar 2025 13:36:01 +0100 [thread overview]
Message-ID: <944705db-906a-47f1-9959-d51e25d22647@proxmox.com> (raw)
In-Reply-To: <9bdf3889-b288-458a-bfe6-5ac9099971de@proxmox.com>
On 3/17/25 13:11, Christian Ebner wrote:
> On 3/17/25 12:56, Dominik Csapak wrote:
>> On 3/17/25 11:32, Christian Ebner wrote:
>>> On 3/17/25 11:07, Dominik Csapak wrote:
>>>> High level comment:
>>>>
>>>> I know it's preexisting, bu does it even make sense to have a 'rate- in' and 'rate-out' for sync
>>>> jobs? would it not make more sense to have a single 'rate' parameter and apply it to both
>>>> directions?
>>>
>>> You mean only as additional parameter for the api endpoint for sync job config creation and
>>> update? Or as parameter for the sync job config itself?
>>>
>>> The former might be the better option, and one can check if both rate and rate-in/out were set
>>> and abort with error in that case or abort with error if a rate-in was configured for a push or
>>> rate-out for a pull?
>>>
>>
>> i had actually imagined 3 options for the sync job config
>> rate: limits both in/out
>> rate-in/out: precedence over rate, limits the respective direction
>>
>> and only expose the 'rate' option on the ui
>
> Okay, that makes sense, but the issue I see there is that per-existing rate limits are not shown in
> the UI anymore, as the `rate` field is now used, while the config has the explicit `rate-in/out` set.
>
> So this would need some merging first, or am I missing something?
no, you're right, but i think we have a few options:
* contrary to what i suggested, don't prioritize rate-in/out, but only use it when 'rate' is not set
* delete rate-in/out when setting the rate via the gui
* as you suggested in the other response, only keep rate-in and rate-out but expose both
(although i can already see the confusion about what is 'in' and what is 'out' regarding sync
direction)
* (other suggestions?)
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-03-17 12:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 17:01 Christian Ebner
2025-03-10 17:01 ` [pbs-devel] [PATCH proxmox-backup 2/2] docs: mention how to set the push sync jobs rate limit Christian Ebner
2025-03-17 10:07 ` [pbs-devel] [PATCH proxmox-backup 1/2] fix: ui: sync job: switch rate limit based on sync direction Dominik Csapak
2025-03-17 10:32 ` Christian Ebner
2025-03-17 10:42 ` Christian Ebner
2025-03-17 11:56 ` Dominik Csapak
2025-03-17 12:11 ` Christian Ebner
2025-03-17 12:36 ` Dominik Csapak [this message]
2025-03-17 12:54 ` Christian Ebner
2025-03-17 13:01 ` Dominik Csapak
2025-03-17 13:17 ` Christian Ebner
2025-03-18 8:18 ` Dominik Csapak
2025-03-17 12:34 ` Christian Ebner
2025-03-18 9:49 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=944705db-906a-47f1-9959-d51e25d22647@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal