Re: [pve-devel] [PATCH v2 qemu-server 2/5] vmstatus: make template property optional

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 11.03.21 11:26, Fabian Ebner wrote:
> to avoid printing 'template: ' with 'qm status <id> --verbose' if it's false.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Breaks pve-manager without the previous patch! (e.g. guest's Start/Shutdown
> buttons won't be updated anymore)
> 

we need to hold that one off for a 7.x release, ideally 7.0

> Changes from v1:
>     * make property optional
> 
>  PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 1410ecb..8326e66 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -2633,7 +2633,7 @@ sub vmstatus {
>  	$d->{diskread} = 0;
>  	$d->{diskwrite} = 0;
>  
> -        $d->{template} = PVE::QemuConfig->is_template($conf);
> +        $d->{template} = 1 if PVE::QemuConfig->is_template($conf);
>  
>  	$d->{serial} = 1 if conf_has_serial($conf);
>  	$d->{lock} = $conf->{lock} if $conf->{lock};
>