all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer] grub: set debconf value to indicate --removable install
@ 2025-03-04  9:45 Fabian Grünbichler
  2025-03-04 10:52 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Grünbichler @ 2025-03-04  9:45 UTC (permalink / raw)
  To: pve-devel

else we risk that the fallback boot manager and the rest of the Grub components
in /boot run out of sync, which can break booting on systems that use that
fallback entry instead of the regular one..

this debconf variable is read by grub-efi-amd64 and shim(-signed) postinst
script, if set, `--force-extra-removable` gets passed to their grub-install
invocations.

Reported on the forum: https://forum.proxmox.com/threads/162989

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
Reproduced by installing using the 8.0 iso, switching over to grub-efi-amd64
and attempting to boot the fallback entry instead of the 'proxmox' one.

Setting the debconf value before installing grub-efi-amd64 makes it all work
as expected.

 Proxmox/Install.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index c0a17b2..57fd899 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -1206,6 +1206,7 @@ postfix postfix/main_mailer_type select No configuration
 keyboard-configuration keyboard-configuration/xkb-keymap select $xkmap
 d-i debian-installer/locale select en_US.UTF-8
 grub-pc grub-pc/install_devices select $grub_install_devices_txt
+grub-efi-amd64 grub2/force_efi_extra_removable boolean true
 _EOD
 
 	my $pkg_count = 0;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH installer] grub: set debconf value to indicate --removable install
  2025-03-04  9:45 [pve-devel] [PATCH installer] grub: set debconf value to indicate --removable install Fabian Grünbichler
@ 2025-03-04 10:52 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-03-04 10:52 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fabian Grünbichler

Am 04.03.25 um 10:45 schrieb Fabian Grünbichler:
> else we risk that the fallback boot manager and the rest of the Grub components
> in /boot run out of sync, which can break booting on systems that use that
> fallback entry instead of the regular one..
> 
> this debconf variable is read by grub-efi-amd64 and shim(-signed) postinst
> script, if set, `--force-extra-removable` gets passed to their grub-install
> invocations.
> 
> Reported on the forum: https://forum.proxmox.com/threads/162989
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> Reproduced by installing using the 8.0 iso, switching over to grub-efi-amd64
> and attempting to boot the fallback entry instead of the 'proxmox' one.
> 
> Setting the debconf value before installing grub-efi-amd64 makes it all work
> as expected.
> 
>  Proxmox/Install.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied with commit message reflowed to match our style guide column width, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-03-04 10:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-04  9:45 [pve-devel] [PATCH installer] grub: set debconf value to indicate --removable install Fabian Grünbichler
2025-03-04 10:52 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal