all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager v2] fix #5251: login: set autocomplete on password and user
Date: Tue, 23 Apr 2024 17:23:20 +0200	[thread overview]
Message-ID: <934bbfcd-1bfb-4be6-9030-f87ccbae6841@proxmox.com> (raw)
In-Reply-To: <20240219103706.256332-1-m.sandoval@proxmox.com>

Am 19/02/2024 um 11:37 schrieb Maximiliano Sandoval:
> By default they have 'autocomplete=off'. From [1]:
> 
>  > In most modern browsers, setting autocomplete to "off" will not
>  > prevent a password manager from asking the user if they would like to
>  > save username and password information, or from automatically filling
>  > in those values in a site's login form. See the autocomplete
>  > attribute and login fields [2].
> 
> [1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
> [2] https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#the_autocomplete_attribute_and_login_fields
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Differences from v1:
>  - Learn how to send emails
>  - Fix 'fix #5251' prefix in commit titles
> 
>  www/manager6/window/LoginWindow.js | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied series, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2024-04-23 15:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 10:37 [pve-devel] " Maximiliano Sandoval
2024-02-19 10:37 ` [pve-devel] [PATCH widget-toolkit v2] fix #5251: tfa: set autocomplete on tfa input form Maximiliano Sandoval
2024-02-19 10:37 ` [pve-devel] [PATCH backup v2] fix #5251: login: set autocomplete on password and user Maximiliano Sandoval
2024-02-19 10:37 ` [pve-devel] [PATCH pmg-gui " Maximiliano Sandoval
2024-04-23 15:23 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=934bbfcd-1bfb-4be6-9030-f87ccbae6841@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal