From: Dominik Csapak <d.csapak@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 0/3] add rrd time frame selector for pve panels
Date: Tue, 19 Aug 2025 10:10:31 +0200 [thread overview]
Message-ID: <9341dc82-4654-4ba8-933c-84ed27d0b88e@proxmox.com> (raw)
In-Reply-To: <DC5K03W5MIRJ.M04ZXDK6RQCU@proxmox.com>
On 8/18/25 14:30, Lukas Wagner wrote:
> On Fri Jun 6, 2025 at 2:10 PM CEST, Dominik Csapak wrote:
>> this series adds an rrd time frame selector to qemu/lxc/node panels for
>> pve.
>>
>> note that my recent series[0] for improving the rrd graphs should be
>> applied first, otherwise there are some situations where the yew
>> application can easily panic.
>>
>> 0: https://lore.proxmox.com/yew-devel/20250530122202.2779300-1-d.csapak@proxmox.com/T/#t
>>
>> Dominik Csapak (3):
>> ui: pve: qemu: add rrd time frame selector
>> ui: pve: lxc: add rrd time frame selector
>> ui: pve: nodes: add rrd time frame selector
>>
>> ui/src/pve/lxc.rs | 26 ++++++++++++++++++--------
>> ui/src/pve/node.rs | 33 ++++++++++++++++++++++-----------
>> ui/src/pve/qemu.rs | 26 ++++++++++++++++++--------
>> 3 files changed, 58 insertions(+), 27 deletions(-)
>
> Looks good to me.
>
> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
> Tested-by: Lukas Wagner <l.wagner@proxmox.com>
>
> (I can apply these if you want, but I didn't so far since I'm not
> familiar at all with the UI code yet)
>
imo you can apply it, but we must bump the yew-comp dependency to 0.5.6
(which is just being uploaded), otherwise we can easily generate panics
when switching between the ranges
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-08-19 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 12:10 Dominik Csapak
2025-06-06 12:10 ` [pdm-devel] [PATCH datacenter-manager 1/3] ui: pve: qemu: add rrd time frame selector Dominik Csapak
2025-06-06 12:10 ` [pdm-devel] [PATCH datacenter-manager 2/3] ui: pve: lxc: " Dominik Csapak
2025-06-06 12:10 ` [pdm-devel] [PATCH datacenter-manager 3/3] ui: pve: nodes: " Dominik Csapak
2025-08-18 12:31 ` [pdm-devel] [PATCH datacenter-manager 0/3] add rrd time frame selector for pve panels Lukas Wagner
2025-08-19 8:10 ` Dominik Csapak [this message]
2025-08-19 12:36 ` [pdm-devel] applied: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9341dc82-4654-4ba8-933c-84ed27d0b88e@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.