From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Leo Nunner <l.nunner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 storage] config: use relative paths for content overrides
Date: Mon, 20 Mar 2023 15:26:02 +0100 [thread overview]
Message-ID: <92f20b6d-81c3-2c70-0d71-e5aa2fb7d699@proxmox.com> (raw)
In-Reply-To: <20230314131456.165418-2-l.nunner@proxmox.com>
Am 14/03/2023 um 14:14 schrieb Leo Nunner:
> Remove the requirement for paths to start with a /, as it might be
> confusing to users.
>
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
> RFC: I'm not really sure how much input validation we want to do here.
> e.g., should we keep the user from appending or prepending slashes (e.g.
> setting the override as /dir/)? Or should we just accept everything?
>
> PVE/Storage/Plugin.pm | 6 +++---
> test/get_subdir_test.pm | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
>
applied, with trivial merge conflict for code-style fixes I did inbetween
resolved, thanks!
Also added a follow up that allows using dots, as long as it's not followed by
another dot, and enforces max-component and a overly-strict max-path length
here already.
next prev parent reply other threads:[~2023-03-20 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 13:14 [pve-devel] [PATCH v2 storage manager docs] Expose content-dirs through GUI + use relative paths Leo Nunner
2023-03-14 13:14 ` [pve-devel] [PATCH v2 storage] config: use relative paths for content overrides Leo Nunner
2023-03-20 14:26 ` Thomas Lamprecht [this message]
2023-03-14 13:14 ` [pve-devel] [PATCH v2 manager] gui: expose content-dirs property in storage edit/create Leo Nunner
2023-03-20 19:25 ` Thomas Lamprecht
2023-03-14 13:14 ` [pve-devel] [PATCH v2 docs] config: remove reference to preceeding / from content-dirs Leo Nunner
2023-03-20 19:10 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92f20b6d-81c3-2c70-0d71-e5aa2fb7d699@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.