From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape: restore: improve variable names
Date: Fri, 10 Nov 2023 13:04:24 +0100 [thread overview]
Message-ID: <925e1f3c-289c-4b45-8dce-2995c49d32ae@proxmox.com> (raw)
In-Reply-To: <7a67722c-11e9-4a16-ad15-64f8dd0ca857@proxmox.com>
On 11/10/23 13:03, Thomas Lamprecht wrote:
> Am 29/09/2023 um 15:39 schrieb Dominik Csapak:
>> some of the variable names did not really tell the full story, so extend
>> them a bit. This makes the intention much clearer.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> www/tape/window/TapeRestore.js | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>>
>
> applied series with Mira's T-b, thanks!
>
> ps. using --- as delimiter for code, as you did in the second patch, breaks
> `git am` a bit, as that command then thinks the boundary between commit
> message and git diff-stat was already hit and truncates the commit message.
> I swapped the triple-minus with triple-backticks.
oops, sorry and good to know. thanks for the fixup!
prev parent reply other threads:[~2023-11-10 12:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 13:39 [pbs-devel] " Dominik Csapak
2023-09-29 13:39 ` [pbs-devel] [PATCH proxmox-backup 2/2] fix #4977: ui: tape: restore: rework snapshot selection logic Dominik Csapak
2023-09-29 15:30 ` Mira Limbeck
2023-10-02 6:47 ` Dominik Csapak
2023-10-02 9:14 ` Mira Limbeck
2023-11-09 7:43 ` [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape: restore: improve variable names Dominik Csapak
2023-11-10 12:03 ` [pbs-devel] applied: " Thomas Lamprecht
2023-11-10 12:04 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=925e1f3c-289c-4b45-8dce-2995c49d32ae@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.