From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexandre Derumier <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH pve-common 1/1] add get_pressure_stat
Date: Sat, 6 Feb 2021 15:13:53 +0100 [thread overview]
Message-ID: <9249d8d7-7e51-28ce-60c9-78683274b832@proxmox.com> (raw)
In-Reply-To: <20201104014137.1368988-2-aderumier@odiso.com>
On 04.11.20 02:41, Alexandre Derumier wrote:
> ---
> src/PVE/CGroup.pm | 43 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/src/PVE/CGroup.pm b/src/PVE/CGroup.pm
> index 4823be2..457502e 100644
> --- a/src/PVE/CGroup.pm
> +++ b/src/PVE/CGroup.pm
> @@ -358,6 +358,49 @@ sub get_memory_stat {
> return $res;
> }
>
> +# Parse some memory data from `memory.stat`
> +sub get_pressure_stat {
> + my ($self) = @_;
> +
> + my $res = {
> + cpu => {
> + some => { avg10 => 10, avg60 => 0, avg300 => 0 }
here too, why 10 as default for the avg over the last 10 seconds?
> + },
> + memory => {
> + some => { avg10 => 10, avg60 => 0, avg300 => 0 },
> + full => { avg10 => 10, avg60 => 0, avg300 => 0 }
> + },
> + io => {
> + some => { avg10 => 10, avg60 => 0, avg300 => 0 },
> + full => { avg10 => 10, avg60 => 0, avg300 => 0 }
> + },
> + };
> +
> + my ($path, $ver) = $self->get_path(undef, 1);
> + if (!defined($path)) {
> + # container or VM most likely isn't running
> + return undef;
> + } elsif ($ver == 2) {
> +
> + foreach my $type (qw(cpu memory io)) {
> + if (my $fh = IO::File->new ("$path/$type.pressure", "r")) {
> + while (defined (my $line = <$fh>)) {
> + if ($line =~ /^(some|full)\s+avg10\=(\d+\.\d+)\s+avg60\=(\d+\.\d+)\s+avg300\=(\d+\.\d+)\s+total\=(\d+)/) {
> + $res->{$type}->{$1}->{avg10} = $2;
> + $res->{$type}->{$1}->{avg60} = $3;
> + $res->{$type}->{$1}->{avg300} = $4;
> + }
> + }
> + $fh->close;
> + }
> + }
> + } else {
> + die "bad cgroup version: $ver\n";
> + }
> +
> + return $res;
> +}
> +
> # Change the memory limit for this container.
> #
> # Dies on error (including a not-running or currently-shutting-down guest).
>
prev parent reply other threads:[~2021-02-06 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 1:41 [pve-devel] [PATCH pve-common 0/1] Cgroups: " Alexandre Derumier
2020-11-04 1:41 ` [pve-devel] [PATCH pve-common 1/1] " Alexandre Derumier
2021-02-06 14:13 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9249d8d7-7e51-28ce-60c9-78683274b832@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.