From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH v3 proxmox-backup] partial fix #5560: client: periodically show backup progress
Date: Fri, 18 Oct 2024 09:20:46 +0200 [thread overview]
Message-ID: <918a092b-703c-485d-9ca1-c48a9c3339b4@proxmox.com> (raw)
In-Reply-To: <537595b3-00bc-4663-907f-1ea1e7a10927@proxmox.com>
Am 17/10/2024 um 17:53 schrieb Christian Ebner:
> On 10/17/24 17:02, Thomas Lamprecht wrote:
>> applied, thanks! With some opinionated line-reduction as follow-up (opinionated
>> because it was OK as is too, and I could have noticed that on the previous
>> review, sorry...)
>>
>> Did not think it through at all, but maybe it makes sense to add the uploaded
>> size also to the upload stats.
>
> For now I do not see much benefit for this, as after consuming the full
> upload stream there are no more chunks queued for upload, so the
> counters already present in `UploadStats` contain the same information.
>
> And this information is already shown to the user at the end of the
> upload as, e.g.:
> ```
> had to backup 1.66 GiB of 285.242 GiB (compressed 1.274 GiB) in 58.52 s
> (average 29.053 MiB/s)
> ```
Ack, thanks for clearing this up to me.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-10-18 7:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 9:33 [pbs-devel] [PATCH v3 proxmox] time: drop trailing space when not showing seconds at end Christian Ebner
2024-10-11 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup] partial fix #5560: client: periodically show backup progress Christian Ebner
2024-10-17 15:02 ` [pbs-devel] applied: " Thomas Lamprecht
2024-10-17 15:53 ` Christian Ebner
2024-10-18 7:20 ` Thomas Lamprecht [this message]
2024-10-18 7:37 ` Christian Ebner
2024-10-18 7:53 ` Thomas Lamprecht
2024-10-18 8:33 ` Christian Ebner
2024-10-18 12:13 ` Thomas Lamprecht
2024-10-17 13:16 ` [pbs-devel] applied: [PATCH v3 proxmox] time: drop trailing space when not showing seconds at end Thomas Lamprecht
2024-10-17 14:40 ` Christian Ebner
2024-10-18 12:12 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=918a092b-703c-485d-9ca1-c48a9c3339b4@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal