Re: [pbs-devel] [PATCH proxmox v2 0/3] fix #6161: time: Split parse_time_spec parser into two

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 13/08/2025 14:43, Maximiliano Sandoval wrote:
> In a support case we found a system with 40:00 as a schedule in a backup job. It
> is possible to entire this calendar event on the web UI.
> 
> As per systemd-analize:
> 
> ```
> $ systemd-analyze calendar 40:00
> Failed to parse calendar specification '40:00': Invalid argument
> ```
> 
> After this series the Proxmox VE web UI won't allow it anymore with an error:
> 
> ```
> Parameter verification failed. (400)
> 
> schedule: invalid format - invalid calendar event '40:00' - unable to parse calendar event at ':00' - Nom(Eof) 
> ```
> 

What about the backward compat concerns from Dominik and Fiona, I see
nothing written anywhere in this series addressing them, or did I just
overlooked that?

Could we treat only serializing strict and deserializing not?

> Differences from v1:
>  - Add cover letter
>  - Reference bugzilla entry #6161
>  - Add test case for 24:00 as per #6161
> 
> Maximiliano Sandoval (3):
>   time: Add traits to DateTimeValue and TimeSpec
>   fix #6161: time: Split parse_time_spec parser into two
>   time: Add more calendat event tests
> 
>  proxmox-time/src/calendar_event.rs  | 109 ++++++++++++++++++++++++++--
>  proxmox-time/src/date_time_value.rs |   2 +-
>  2 files changed, 103 insertions(+), 8 deletions(-)
> 



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel