Re: [pbs-devel] [PATCH proxmox/proxmox-backup] add 'pbs-shell' tool

[Hannes Laimer <h.laimer@proxmox.com>]

I just noticed two things while testing:
 - if an endpoint expects a parameter called 'path'(e.g. POST /config
     /datastore), the parameter conflicts with the api path itself
 - even though commands like verify(POST /admin/datastore/<name>/verify)
or gc(POST /admin/datastore/<name>/gc) are started and run successfully,
`Error: control socket connect failed - Connection refused (os error
111)` is displayed almost always at the end.

Note: For testing I applied the patches on
b65dfff574f44e5a60db3903d2226f4dbe386b7a, I assume the moving of stuff
after that should not effect the functionality

Am 09.09.21 um 15:48 schrieb Dominik Csapak:
> this series adds the tool 'pbs-shell', similar to 'pvesh' and 'pmgsh'
> this tool is intended mainly for debugging, but can be useful for
> api calls not exposed via the client/manager.
> 
> proxmox (and the dependency in proxmox-backup) need to be bumped
> 
> proxmox-backup patches 2-5 are not strictly necessary, but improve
> the api so that the 'ls' command works better
> (there are still some api paths to be fixed)
> 
> proxmox:
> 
> Dominik Csapak (1):
>   proxmox: generate_usage_str: don't require static lifetimes
> 
>  proxmox/src/api/cli/format.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> proxmox-backup:
> 
> Dominik Csapak (5):
>   add 'pbs-shell' utility
>   api2: add missing token list match_all property
>   api2: disks/directory: refactor BASE_MOUNT_DIR
>   api2: disks/directory: add 'name' property to directory mount listing
>   api2: nodes: add missing node list api call
> 
>  Makefile                                     |   2 +
>  debian/pbs-shell.bc                          |   3 +
>  debian/proxmox-backup-server.bash-completion |   1 +
>  debian/proxmox-backup-server.install         |   3 +
>  docs/Makefile                                |   8 +
>  docs/pbs-shell/description.rst               |   3 +
>  docs/pbs-shell/man1.rst                      |  40 ++
>  src/api2/access/user.rs                      |  35 +-
>  src/api2/mod.rs                              |   4 +-
>  src/api2/node/disks/directory.rs             |  15 +-
>  src/api2/node/mod.rs                         |  12 +-
>  src/bin/pbs-shell.rs                         | 502 +++++++++++++++++++
>  zsh-completions/_pbs-shell                   |  13 +
>  13 files changed, 628 insertions(+), 13 deletions(-)
>  create mode 100644 debian/pbs-shell.bc
>  create mode 100644 docs/pbs-shell/description.rst
>  create mode 100644 docs/pbs-shell/man1.rst
>  create mode 100644 src/bin/pbs-shell.rs
>  create mode 100644 zsh-completions/_pbs-shell
>