From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Tiago Sousa <joao.sousa@eurotux.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [RFC pve-manager 1/1] add ha node maintenance mode to the UI and API
Date: Tue, 3 Jun 2025 08:35:19 +0200 [thread overview]
Message-ID: <90de8fa6-0e31-4273-adf3-ad337ec39446@proxmox.com> (raw)
In-Reply-To: <20250602161052.170879-2-joao.sousa@eurotux.com>
Am 02.06.25 um 18:10 schrieb Tiago Sousa:
> Signed-off-by: Tiago Sousa <joao.sousa@eurotux.com>
> ---
> PVE/API2/Nodes.pm | 45 ++++++++++++++++++++++++++++++++++++
Thanks for your patch, some high level comment:
As the API touches HA it should also go into the pve-ha-manager repo, there it
could directly check the current state, and queue a CRM command directly, without
using run_command.
I'd also place the UI there in the HA overview, as its IMO required for the admin
to check the current HA stack's state before scheduling anything here.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-06-03 6:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250602161052.170879-1-joao.sousa@eurotux.com>
2025-06-02 16:10 ` Tiago Sousa via pve-devel
[not found] ` <20250602161052.170879-2-joao.sousa@eurotux.com>
2025-06-03 6:35 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90de8fa6-0e31-4273-adf3-ad337ec39446@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=joao.sousa@eurotux.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.