From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Timothy Nicholson <t.nicholson@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] fix #5847: ui: gettextize several strings in ui
Date: Tue, 12 Nov 2024 10:16:41 +0100 [thread overview]
Message-ID: <907f5afc-f581-4e9b-892e-d5d0f5f464f2@proxmox.com> (raw)
In-Reply-To: <20241111113519.118949-1-t.nicholson@proxmox.com>
one comment inline
On 11/11/24 12:35, Timothy Nicholson wrote:
> Several strings that should probably also be translated now use
> the gettext function to be translated.
>
> Signed-off-by: Timothy Nicholson <t.nicholson@proxmox.com>
> ---
> [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5847
>
> www/manager6/Workspace.js | 2 +-
> www/manager6/ceph/OSD.js | 6 +++---
> www/manager6/ceph/OSDDetails.js | 2 +-
> www/manager6/form/VMCPUFlagSelector.js | 24 ++++++++++++------------
> www/manager6/qemu/ProcessorEdit.js | 2 +-
> www/manager6/window/Settings.js | 6 +++---
> 6 files changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
> index 52c66108..56dde151 100644
> --- a/www/manager6/Workspace.js
> +++ b/www/manager6/Workspace.js
> @@ -388,7 +388,7 @@ Ext.define('PVE.StdWorkspace', {
> },
> },
> {
> - text: 'TFA',
> + text: gettext('TFA'),
is it a good idea to translate this? it's mostly a technical term (which we generally don't
translate), but i'd be swayed if there is an actual example where a language want
to have that translated...
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-12 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 11:35 Timothy Nicholson
2024-11-12 9:16 ` Dominik Csapak [this message]
2024-11-12 9:27 ` Shannon Sterz
2024-11-12 9:28 ` Timothy Nicholson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=907f5afc-f581-4e9b-892e-d5d0f5f464f2@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.nicholson@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.