Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 10/10/2023 um 15:19 schrieb Aaron Lauterer:
>>>
>>>
>>> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
>>> index 7e9ec44d..8469a7c3 100644
>>> --- a/www/manager6/storage/DirEdit.js
>>> +++ b/www/manager6/storage/DirEdit.js
>>> @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
>>>           name: 'shared',
>>>           uncheckedValue: 0,
>>>           fieldLabel: gettext('Shared'),
>>> +        autoEl: {
>>> +            tag: 'div',
>>> +            'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
>>> +        }
>>
>> eslint complains about missing trailing comma
> 
> hmm, when did that happen... now it does it too for me. Will send another version with it fixed.

We always had that rule enabled, it's a warning one, so `make install` will
only output the warning but continue, to make modify-build-test cycles easier,
but when building a debian package all the eslint warnings become errors.

There's a slight possibility that an earlier eslint had a false-negative here,
but tbh., I'd find that a bit odd as it's a relatively simple check.