all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve-container 0/1] vmstatus: add pressure stats
@ 2020-11-04  1:42 Alexandre Derumier
  2020-11-04  1:42 ` [pve-devel] [PATCH pve-container 1/1] " Alexandre Derumier
  0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Derumier @ 2020-11-04  1:42 UTC (permalink / raw)
  To: pve-devel

need pve-common patches serie

Alexandre Derumier (1):
  vmstatus: add pressure stats

 src/PVE/LXC.pm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

-- 
2.20.1




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure stats
  2020-11-04  1:42 [pve-devel] [PATCH pve-container 0/1] vmstatus: add pressure stats Alexandre Derumier
@ 2020-11-04  1:42 ` Alexandre Derumier
  2021-02-06 14:12   ` Thomas Lamprecht
  0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Derumier @ 2020-11-04  1:42 UTC (permalink / raw)
  To: pve-devel

---
 src/PVE/LXC.pm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 5cfcf28..ad1460c 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -291,6 +291,24 @@ sub vmstatus {
 	} else {
 	    $d->{cpu} = 0;
 	}
+
+	if (defined(my $pressure = $cgroups->get_pressure_stat())) {
+	    $d->{pressure} = $pressure;
+	} else {
+	    $d->{pressure} = {
+		cpu => {
+		    some => { avg10 => 10, avg60 => 0, avg300 => 0 }
+		},
+		memory => {
+		    some => { avg10 => 10, avg60 => 0, avg300 => 0 },
+		    full => { avg10 => 10, avg60 => 0, avg300 => 0 }
+		},
+		io => {
+		    some => { avg10 => 10, avg60 => 0, avg300 => 0 },
+		    full => { avg10 => 10, avg60 => 0, avg300 => 0 }
+		},
+	    };
+	}
     }
 
     my $netdev = PVE::ProcFSTools::read_proc_net_dev();
-- 
2.20.1




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure stats
  2020-11-04  1:42 ` [pve-devel] [PATCH pve-container 1/1] " Alexandre Derumier
@ 2021-02-06 14:12   ` Thomas Lamprecht
  2021-02-07 13:42     ` aderumier
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Lamprecht @ 2021-02-06 14:12 UTC (permalink / raw)
  To: Proxmox VE development discussion, Alexandre Derumier

sorry for the late reply!

On 04.11.20 02:42, Alexandre Derumier wrote:
> ---
>  src/PVE/LXC.pm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index 5cfcf28..ad1460c 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -291,6 +291,24 @@ sub vmstatus {
>  	} else {
>  	    $d->{cpu} = 0;
>  	}
> +
> +	if (defined(my $pressure = $cgroups->get_pressure_stat())) {
> +	    $d->{pressure} = $pressure;
> +	} else {
> +	    $d->{pressure} = {
> +		cpu => {
> +		    some => { avg10 => 10, avg60 => 0, avg300 => 0 }

Setting avg10 to 10 seems wrong?


> +		},
> +		memory => {
> +		    some => { avg10 => 10, avg60 => 0, avg300 => 0 },
> +		    full => { avg10 => 10, avg60 => 0, avg300 => 0 }
> +		},
> +		io => {
> +		    some => { avg10 => 10, avg60 => 0, avg300 => 0 },
> +		    full => { avg10 => 10, avg60 => 0, avg300 => 0 }
> +		},
> +	    };
> +	}
>      }
>  
>      my $netdev = PVE::ProcFSTools::read_proc_net_dev();
> 





^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure stats
  2021-02-06 14:12   ` Thomas Lamprecht
@ 2021-02-07 13:42     ` aderumier
  0 siblings, 0 replies; 5+ messages in thread
From: aderumier @ 2021-02-07 13:42 UTC (permalink / raw)
  To: Thomas Lamprecht, Proxmox VE development discussion

Le samedi 06 février 2021 à 15:12 +0100, Thomas Lamprecht a écrit :
> 
> Setting avg10 to 10 seems wrong?
Sorry, I think it's was some debug value when I was testing it.


I have resend both pve-common && pve-container patches.

Thanks for the review !



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure stats
  2022-05-25  6:52 [pve-devel] [PATCH-SERIES cluster/common/qemu-server/lxc/manager] add new metric stats in single rrd Alexandre Derumier
@ 2022-05-25  6:52 ` Alexandre Derumier
  0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Derumier @ 2022-05-25  6:52 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
 src/PVE/LXC.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index fe63087..af47ff9 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -299,6 +299,8 @@ sub vmstatus {
 	} else {
 	    $d->{cpu} = 0;
 	}
+
+	$d->{pressure} = $cgroups->get_pressure_stat();
     }
 
     my $netdev = PVE::ProcFSTools::read_proc_net_dev();
-- 
2.30.2




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-25  6:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-04  1:42 [pve-devel] [PATCH pve-container 0/1] vmstatus: add pressure stats Alexandre Derumier
2020-11-04  1:42 ` [pve-devel] [PATCH pve-container 1/1] " Alexandre Derumier
2021-02-06 14:12   ` Thomas Lamprecht
2021-02-07 13:42     ` aderumier
2022-05-25  6:52 [pve-devel] [PATCH-SERIES cluster/common/qemu-server/lxc/manager] add new metric stats in single rrd Alexandre Derumier
2022-05-25  6:52 ` [pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure stats Alexandre Derumier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal