Re: [pdm-devel] [RFC PATCH datacenter-manager 5/5] ui: main menu: use different icon for pbs remotes

[Dominik Csapak <d.csapak@proxmox.com>]

On 12/4/25 9:00 PM, Thomas Lamprecht wrote:
> Am 04.12.25 um 15:24 schrieb Dominik Csapak:
>> In most of the UI, we use 'server' for remotes, 'building' for PVE nodes
>> and 'building-o' for PBS nodes.
>>
>> In the main menu we don't have the information if a remote is a single
>> node or not for PVE, but we know if it's PBS. So show the 'building-o'
>> for PBS remotes.
>>
>> This makes it possible to see which kind of remote it is before
>> clicking, and wihtout inventing a custom naming scheme.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> We can of course choose different icons here if wanted, e.g. 'floppy-o'
>> for pbs remotes?
> 
> We should stay consistent though, so this would have to change everywhere,
> and I'm not so sure if just a floppy-o it's own is great UX.
> 
> And (lacking) consistency is actually my main gripe with this patch, as we
> use "fa-server" for remotes in general, but now we do use a remote-type
> specific icon for PBS but the generic one for PVE.
> 
> Maybe we should choose another way to differentiate this than the icon,
> at least until we really got (marketing blessed) product icons (don't hold
> your breadth for that). One not-so-thought-out idea might be to show the
> tree letter abbreviation aligned to the right of the icon+label menu entry
> and styled such that it's rather subtle, like a shallow engraving.
> One would need to try to see if it looks OK, but that would at least be much
> more obvious than just some different (still relatively generic) icons.
> 

yeah makes sense, the lack of consistency is why i sent it as RFC.
Thanks for your feedback! I'll play around with the abbreviation and 
items, if I find something that fits, I'll send a new patch.

>>
>> Maybe the best option would be to create some custom product icons that
>> we could use here and maybe for the favicon, etc. ?
>>
>>   ui/src/main_menu.rs | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/ui/src/main_menu.rs b/ui/src/main_menu.rs
>> index 18988eaf..8d44d8f1 100644
>> --- a/ui/src/main_menu.rs
>> +++ b/ui/src/main_menu.rs
>> @@ -347,7 +347,10 @@ impl Component for PdmMainMenu {
>>                   &mut content,
>>                   &remote.id,
>>                   &format!("remote-{}", remote.id),
>> -                Some("fa fa-server"),
>> +                match remote.ty {
>> +                    RemoteType::Pve => Some("fa fa-fw fa-server"),
>> +                    RemoteType::Pbs => Some("fa fa-fw fa-building-o"),
>> +                },
>>                   {
>>                       let remote = remote.clone();
>>                       move |_| match remote.ty {
> 



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel