From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] applied: [PATCH pve-common 1/1] inotify/interfaces: use 'ip link' instead of /proc/net/dev
Date: Wed, 23 Jul 2025 17:33:36 +0200 [thread overview]
Message-ID: <8fc4304b-f718-4881-ad0a-3b9495badeb9@proxmox.com> (raw)
In-Reply-To: <0ea3edeb-a110-455e-812e-7b9f019d6c77@proxmox.com>
Am 23.07.25 um 17:16 schrieb Stefan Hanreich:
> On 7/23/25 17:06, Thomas Lamprecht wrote:
>
> [snip]
>
>> I do not recall for sure anymore, but do differing bridge-ports work
>> transparently with the ifupdown2 changes from Christoph. With that it might be
>> nice to support it here too in the midterm, but that is certainly not a blocker
>> for now.
>
> I'm not sure if I understand 100% - do you mean if the name used in
> bridge-ports differs from the name of the referenced interface in
> /e/n/i? That doesn't work currently, since the validation breaks.
Yeah no, I mean does it work for ifupdown2 now? As every situation
that works there but confuses our e/n/i parser is naturally not ideal
(for the long term).
> I've discussed this initially with Dominik today, and we'd need to
> resolve altnames every time we look up names from bridge-ports, etc.
That sounds like this is some expensive and high frequency operation,
but isn't it really only required when managing the node network or
wanting to do getting all available interfaces or doing some sanity
checks, i.e. things that invovle parsing the network config, where we
now have the altname map queried anyway?
Or am I overlooking something?
> If we want to support mixing names in the configuration, then we'd
> additionally have to construct a temporary, merged, configuration and
> validate against that.
If ifupdown2 currently still doesn't supports that we're good in any
case, if it supports it would be nice to keep our stack consistent with
ifudpown2, but as hinted, not pressing now especially as our stack, as
you mentioned, never creates such a mixed config anyway.
>
>> Applied with perltidy formatting changes squashed in, thanks!
>
> I will pay more attention to running `make tidy` in the future, still
> not used to the fact that we actually have a formatter now - sorry.
>
No worries, I forget it myself more often than I'd like to
admit, but it gets better with time ^^
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-23 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 14:21 [pve-devel] " Stefan Hanreich
2025-07-23 15:02 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-23 15:16 ` Stefan Hanreich
2025-07-23 15:33 ` Thomas Lamprecht [this message]
2025-07-23 15:53 ` Stefan Hanreich
2025-07-23 15:57 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fc4304b-f718-4881-ad0a-3b9495badeb9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.