all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 2/2] bail if mount point already exists for directories
Date: Tue, 10 Nov 2020 09:37:58 +0100	[thread overview]
Message-ID: <8f8c3b46-74dc-a9be-1229-feda9c37c5e2@proxmox.com> (raw)
In-Reply-To: <20201105133629.9802-2-f.ebner@proxmox.com>

On 05.11.20 14:36, Fabian Ebner wrote:
> similar to what we do for zfs. By bailing before partitioning, the disk is
> still considered unused after a failed attempt.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> There is no other caller for create_datastore_mount_unit, so the check from
> the not yet applied https://lists.proxmox.com/pipermail/pbs-devel/2020-November/001297.html
> is superseded by this.
> 
>  src/api2/node/disks/directory.rs | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
> 
>

applied, thanks!

maybe we should loosen this check a bit and also allow existing but empty
directories?  But for now OK, this is in a pretty specific namespace anyway.




  reply	other threads:[~2020-11-10  8:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 13:36 [pbs-devel] [PATCH proxmox-backup 1/2] mount zpools created via API under /mnt/datastore Fabian Ebner
2020-11-05 13:36 ` [pbs-devel] [PATCH proxmox-backup 2/2] bail if mount point already exists for directories Fabian Ebner
2020-11-10  8:37   ` Thomas Lamprecht [this message]
2020-11-10  8:37 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] mount zpools created via API under /mnt/datastore Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f8c3b46-74dc-a9be-1229-feda9c37c5e2@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal