all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>,
	Stefan Reiter <s.reiter@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #3359: fix blocking writes in async code during pxar create
Date: Wed, 24 Mar 2021 08:43:06 +0100	[thread overview]
Message-ID: <8e0fc4aa-c1c2-7815-c637-8d28b4b3b212@proxmox.com> (raw)
In-Reply-To: <135688083.868.1616570239599@webmail.proxmox.com>

On 3/24/21 08:17, Dietmar Maurer wrote:
>> Fixes: 6afb60abf557 ("asyncify pxar create_archive")
> 
> I am not sure, but maybe 6afb60abf557 is also the cause for
> the performance regression?
> 
> (reported at https://bugzilla.proxmox.com/show_bug.cgi?id=3174)
> 

i mean not the perfect benchmark, but here on a relatively
empty vm (~2GB root disk) with 4 cores + 4GiB Memory

there is no measurable difference between before
that commit and after

(a backup of / takes ~15s in both cases)




  reply	other threads:[~2021-03-24  7:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24  7:17 Dietmar Maurer
2021-03-24  7:43 ` Dominik Csapak [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-24  7:47 Dietmar Maurer
2021-03-23 10:12 Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e0fc4aa-c1c2-7815-c637-8d28b4b3b212@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=dietmar@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.reiter@proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal