From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: FirewallRules.js: fix #3049 wider rule number column
Date: Thu, 1 Oct 2020 16:44:00 +0200 [thread overview]
Message-ID: <8d5d5ea5-3393-b34a-94e0-994c416bb9f7@proxmox.com> (raw)
In-Reply-To: <20201001121840.23081-1-a.lauterer@proxmox.com>
On 01.10.20 14:18, Aaron Lauterer wrote:
> Allows 2 digits rule numbers to be visible in the column. Made it a bit
> wider than needed to account for potentially wider font rendering on
> different platforms.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> www/manager6/grid/FirewallRules.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
for the future please:
* do *not* use file endings in the commit message, if not really relevant.
* put the "fixes #12345:" at the beginning.
No use but makes it harder to read (and get sane, user readable d/changelogs entries from)
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
this time still: applied, thanks!
next prev parent reply other threads:[~2020-10-01 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 12:18 [pve-devel] " Aaron Lauterer
2020-10-01 14:44 ` Thomas Lamprecht [this message]
2020-10-01 15:10 ` Thomas Lamprecht
2020-10-01 15:22 ` Aaron Lauterer
2020-10-02 12:52 ` Aaron Lauterer
2021-02-19 16:45 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d5d5ea5-3393-b34a-94e0-994c416bb9f7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.