From: Friedrich Weber <f.weber@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager/network 0/2] Improve FRR reloading logic
Date: Tue, 5 Aug 2025 10:57:40 +0200 [thread overview]
Message-ID: <8cad4191-6b96-49cb-9cd8-579b28607d3d@proxmox.com> (raw)
In-Reply-To: <20250805082926.48280-1-s.hanreich@proxmox.com>
On 05/08/2025 10:29, Stefan Hanreich wrote:
> Follow-up to the stop gap fix in [1].
>
> This should handle all cases that we need to consider:
>
> * Do not overwrite existing FRR configurations, unless we need to generate our
> own FRR configuration.
>
> * Do not trigger a FRR enable when reloading the host configuration, even though
> there is no FRR configuration.
>
> * Overwrite the FRR configuration with an empty configuration if all SDN
> entities using FRR got deleted.
>
> * Regenerate the FRR configuration when the host network configuration changes,
> since this might affect the generated FRR configuration.
>
>
> [1] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=6c5295a1cdb6ec872ddf997cae030817dffff106
Thanks for the patch! Installed on my host that doesn't use fabrics (frr is disabled and not running), and when applying the network configuration, frr is not enabled.
When applying my SDN configuration (that only uses Simple Zones, no fabrics), frr is not enabled either.
I haven't tested on a setup *with* fabrics, though.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-05 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 8:29 Stefan Hanreich
2025-08-05 8:29 ` [pve-devel] [PATCH pve-manager 1/1] network: improve " Stefan Hanreich
2025-08-05 8:29 ` [pve-devel] [PATCH pve-network 1/1] sdn: api: always send regenerate-frr parameter Stefan Hanreich
2025-08-05 8:57 ` Friedrich Weber [this message]
2025-08-05 9:11 ` [pve-devel] [PATCH manager/network 0/2] Improve FRR reloading logic Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cad4191-6b96-49cb-9cd8-579b28607d3d@proxmox.com \
--to=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.