[pve-devel] [PATCH manager] ui: Utils: remove unnecessary render_kvm_vga_driver

[pve-devel] [PATCH manager] ui: Utils: remove unnecessary render_kvm_vga_driver

[Dominik Csapak]

the 'value' here is already the rendered text, passing it through
render again does not make sense

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/Utils.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index aafe359a..d6aeaf31 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -653,9 +653,9 @@ Ext.define('PVE.Utils', {
     },
 
     kvm_vga_driver_array: function() {
-	var data = [['__default__', PVE.Utils.render_kvm_vga_driver('')]];
+	var data = [['__default__', Proxmox.Utils.defaultText]];
 	Ext.Object.each(PVE.Utils.kvm_vga_drivers, function(key, value) {
-	    data.push([key, PVE.Utils.render_kvm_vga_driver(value)]);
+	    data.push([key, value]);
 	});
 
 	return data;
-- 
2.30.2

[pve-devel] applied: [PATCH manager] ui: Utils: remove unnecessary render_kvm_vga_driver

[Thomas Lamprecht]

On 09.03.22 15:09, Dominik Csapak wrote:
> the 'value' here is already the rendered text, passing it through
> render again does not make sense
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/Utils.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

same held true for the kvm_keymap_array and console_viewer_array, actually I reworked the whole three quite
a bit more, using Object.entries() directly allows to shave off quite some code, order seems till fine here
too.

applied, thanks!