From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: Utils: remove unnecessary render_kvm_vga_driver
Date: Tue, 26 Apr 2022 09:10:02 +0200 [thread overview]
Message-ID: <8c676ae7-573f-bc38-d21b-bf1d7d3f08cd@proxmox.com> (raw)
In-Reply-To: <20220309140914.994552-1-d.csapak@proxmox.com>
On 09.03.22 15:09, Dominik Csapak wrote:
> the 'value' here is already the rendered text, passing it through
> render again does not make sense
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/Utils.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
same held true for the kvm_keymap_array and console_viewer_array, actually I reworked the whole three quite
a bit more, using Object.entries() directly allows to shave off quite some code, order seems till fine here
too.
applied, thanks!
prev parent reply other threads:[~2022-04-26 7:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 14:09 [pve-devel] " Dominik Csapak
2022-04-26 7:10 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c676ae7-573f-bc38-d21b-bf1d7d3f08cd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal